Conversation
…ed (#9223) * fix: prevent closing combobox when section headers are clicked * add unit test --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
* fix docs typos * undo locale plugin changes
* Expose closeOnSelect prop * rename to shouldCloseOnSelect, add to menu section and menu * Update packages/@react-aria/menu/src/useMenuItem.ts * follow up * fix jsdocs defaults * fix some formatting --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com> Co-authored-by: Robert Snow <snowystinger@gmail.com> Co-authored-by: Robert Snow <rsnow@adobe.com>
The Link component was missing the `id` prop in its TypeScript interface, even though it worked at runtime via filterDOMProps. This adds DOMProps to LinkProps interface to expose the id prop, matching the pattern used by other components like OverlayArrow and FieldError Fixes #9348
* fix: ensure contains is used as default filter in ComboBox * add test --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
* feat: support modern useEffectEvent * chore: require callback * fix: backwards compatibility
* handle rendering code blocks without language * remove unused text language * remove classname lang extraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )